fix: throw an error if incorrect ledger is used #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/v0.46.x-celestia #374 +/- ##
============================================================
- Coverage 64.33% 64.31% -0.02%
============================================================
Files 761 761
Lines 76378 76386 +8
============================================================
- Hits 49139 49130 -9
- Misses 24463 24481 +18
+ Partials 2776 2775 -1
|
Run it with `go test ./... -tags "cgo,ledger,test_ledger_mock,norace" -run "TestSignWithLedger"`
|
Run unit tests via: Add this to your VSCode workspace settings to get rid of gopls errors: "go.buildTags": "cgo,ledger,test_ledger_mock,norace", |
evan-forbes
approved these changes
Mar 12, 2024
cmwaters
approved these changes
Mar 12, 2024
cmwaters
merged commit 8b5e30b
into
celestiaorg:release/v0.46.x-celestia
32 checks passed
rootulp
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivated by this Slack thread. This PR is similar to cosmos#19691